Skip to content

Pin CI PHP images to the 2026-11-19 security releases - #169

Merged
rmcdaniel merged 2 commits into
mainfrom
general/php-2026-11-19-pins
Nov 19, 2026
Merged

rmcdaniel merged 2 commits into
mainfrom
general/php-2026-11-19-pins

Conversation

@rmcdaniel

Copy link
Copy Markdown
Member

What changed

Pins the CI and test-tooling PHP containers to the PHP security releases of 2026-11-19 (PHP 8 ChangeLog).

  • scripts/ci/php-container-images.json: the immutable official image indexes for the containerized test matrix, plus the PHAR, reproducible-build and Rust source-reference profiles:
    • 8.2: php:8.2.36-cli-bookworm@sha256:0a5ed0098915c11e1db8729b81bdb9a1bf12a998cc5e5b2f9a640afb6104dbe1 (was 8.2.35 ce09ca1d…)
    • 8.4: php:8.4.28-cli-bookworm@sha256:85da896b3eeb8bcd83fe612e51a529b7d5983a1fab92ef5f63c7ac6e2842fc46 (was 8.4.27 b3e907a1…)
    • 8.5: php:8.5.13-cli-bookworm@sha256:d6991172c4282d2a09d6418073923a81664173bb0a0e07a16663a9a645746092 (was 8.5.12 050713ce…)
  • scripts/ci/probe-php-phar-runtime.php and scripts/ci/probe-php-reference-runtime.php: the exact-runtime gate now requires 8.4.28.
  • .github/workflows/release-rust.yml upgrade-from-2x: LEGACY_PHP_IMAGE moves to the 8.4.28 index. This image is only the interpreter that runs the published 2.3.5 dw.phar in the upgrade check. The frozen artifact is that PHAR, and the job still verifies it by LEGACY_PHAR_SHA256, so the PHP runtime is test tooling and does not need to stay frozen. The new index includes native linux/amd64 and linux/arm64 manifests, as the job requires.

No hash or provenance record in this repository covers these pins. No test asserts the literal digests, and docker/php-ci/README.md names no versions. The central APT guard (require-fixed-bookworm-apt.sh at 18783be6) is checked at build time, not tied to the image, and all three new images pass it.

Tests (lab4, capped Docker containers, repo mounted read-only)

  • Each new image: PHP_VERSION is 8.2.36, 8.4.28 or 8.5.13, and the pinned central require-fixed-bookworm-apt.sh (sha256 verified) reports fixed_bookworm_apt=true, apt/libapt-pkg6.0 2.6.2.
  • probe-php-phar-runtime.php and probe-php-reference-runtime.php on the 8.4.28 image with phar.ini or reference.ini mounted: the exact-version and profile gate passes. Both probes then stop in probe-php-test-runtime.php, as expected for the stock image, because pcntl is added only by the CI Dockerfile. The full built-image probe runs in this PR's CI.
  • Python (PyYAML 6.0.2, Node 22 available): test-release-cache-policy.py 8 OK, test-release-rust-workflow.py 51 OK, test-apt-no-retries.py 2 OK, test-build-workflow.py 4 OK, test-php-container-launcher.py 6 OK, test_php_phar_container.py 5 OK (1 skipped), test_php_reference_container.py 5 OK (1 skipped), test_php_repro_container.py 7 OK (2 skipped). The skips need a built CI image.
  • Node --test: test-standalone-runtime.js 10/10, test-release-workflow-metadata.js 43/43, test-standalone-dependencies.js 8/8, test-cli-release-channel.js 9/9, test-cli-upgrade-result.js 5/5.
  • PHPUnit: no PHPUnit test reads the changed files, so none was run here. The full matrix runs in CI.

Deliberately unchanged

  • The dormant PHP standalone/PHAR release path stays at 8.4.27: release.yml (PHP_VERSION, PHP_VERSION_WINDOWS), scripts/ci/verify-standalone-runtime.js (MINIMUM_PHP_VERSION), test-standalone-runtime.js and the ReleaseInstallerContractTest assertions about release.yml. The shipped CLI is now Rust (2.11.0). The PHP standalone line last shipped at 2.3.9, and those release jobs are skipped. Any future PHP standalone release would first need a static-php-cli qualification at a patched PHP version.
  • The PHP 8.3 cell (Test (PHP 8.3)) uses the central setup-php-linux action at a pinned commit with a minor-only php-version: '8.3' selector. That pin is owned centrally, not in this repository.
  • The central durable-workflow/.github inventory record docker/apt/php-8.4.27-cli-bookworm.v1.json describes the old 8.4.27 parent. It is source inventory in another repository and is not consumed by this build.

🤖 Generated with Claude Code

Bump the immutable official PHP image indexes used by the containerized
CI test, PHAR, reproducible-build and Rust source-reference profiles to
PHP 8.2.36, 8.4.28 and 8.5.13 (bookworm), require the exact 8.4.28
runtime in the PHAR and source-reference probes, and move the Rust
release workflow's legacy 2.3.5 PHAR upgrade check onto the 8.4.28
index. The dormant PHP standalone release path stays at 8.4.27.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@rmcdaniel

Copy link
Copy Markdown
Member Author

CI blocker, outside this repository: Central action policy preflight fails with Reviewed Composer runtime source differs: scripts/ci/php-container-images.json. The central record durable-workflow/.github qualification/composer-container-trust.json (cli target) pins the file SHA-256 of the changed runtime sources. Before this PR can qualify, those pins need the following updates:

  • scripts/ci/php-container-images.json: 85c87a2dff21225109581876befc00177c62824e44c044765dc921879ca41a4d → f0f040c863c4ec8c200336c6f11988d06da24a09e5f7db08c85bde48a2e7a198 (4 entries)
  • scripts/ci/probe-php-phar-runtime.php: 28deb9870754643ad6a89a6c1b107446f11fef18d0dd9f8f1c09170b7fec1ecf → 2fe14289f6739d83b726f5e271fb3d554f90484fe8f3685d2a368693beaf91bb (2 entries)
  • scripts/ci/probe-php-reference-runtime.php: 855e21c5d444038f116ea5523494d8b28c2cb59053e932cf1fff2e61c7efd1c2 → 4b102615e8971255c1e3d08062510678c181f3dd5ace9d8ce7be83adaf7295cd (1 entry)

Modes are unchanged (0644). Because the preflight failed, the containerized PHP 8.2/8.4/8.5, PHAR and reproducible-build cells were skipped. Test (PHP 8.3) also failed separately: the central setup-php-linux@5c1ddbff returned Bound PHP setup refused: HTTPError 404. That action does not read any file this PR changes.

@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel merged commit b86c4c4 into main Nov 19, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant